search

travis-ci / job-board

have a job? need a job? no jobs? all the jobs!
MIT License
9 stars 9 forks source link

install jq on heroku dyno #79

Closed igorwwwwwwwwwwwwwwwwwwww closed 6 years ago

igorwwwwwwwwwwwwwwwwwwww commented 6 years ago

the script for syncing the images that runs on heroku is currently erroring out with:

./script/sync-images: line 140: jq: command not found

this change, as well as:

heroku buildpacks:add https://github.com/heroku/heroku-buildpack-apt

should ensure that jq is installed.

bogdanap commented 6 years ago

I noticed that we should already be installing jq here: https://github.com/travis-ci/job-board/blob/master/script/sync-images#L139, so I'd be curious to first find out what went wrong there before replacing the behaviour.

bogdanap commented 6 years ago

Oh, on second thought, I guess the command not found message is the output from the initial check (jq --version), before we actually install jq. That being said, I think I like the buildpack idea better than the current approach.

igorwwwwwwwwwwwwwwwwwwww commented 6 years ago

ah, totally missed that, very nice find!

i'm happy to drop the apt buildpack and instead change the check to use command -v. awaiting @meatballhat input. :)

igorwwwwwwwwwwwwwwwwwwww commented 6 years ago

Closing stale PR.