search

travis-ci / travis-watcher-macosx

[DEPRECATED] A Travis CI client for Mac OS X.
MIT License
95 stars 9 forks source link

No notifications after reconnecting #4

Closed gharlan closed 12 years ago

gharlan commented 12 years ago

After reconnecting to internet (e. g. after standby mode) no notifications are triggered.

Updating Pusher framework will fix it.

PS: Are you interested in an implementation of this approach: https://github.com/lukeredpath/libPusher#handling-network-connectivity-errors-and-disconnects? At first I thought this would fix the bug and I implemented it, so I could open a pull request if you want. But to fix the bug, it isn't necessary.

joshk commented 12 years ago

Hi @gharlan,

Any and all help fixing bugs and updating deps would be awesome.

If you send me a PR I will merge and give you commit rights :)

<3<3<3

Josh

sarahhodne commented 12 years ago

Like @joshk said, if you can submit a PR for the bug that would be A+, and if you already have Reachability implemented, a PR for that too would be great.

gharlan commented 12 years ago

(added commit)

joshk commented 12 years ago

@dvyjones I'll let you merge and test :)