search

travis-ci / travis-yaml

parses, normalizes, validates and serializes your .travis.yml
http://yaml.travis-ci.org/
MIT License
170 stars 66 forks source link

Support on_pull_requests for hipchat and slack #125

Closed thomaseizinger closed 4 years ago

thomaseizinger commented 6 years ago

This PR adds support for the on_pull_requests flag documented here: https://docs.travis-ci.com/user/notifications/#Notifications-of-PR-builds

I don't have much experience in ruby and wasn't sure if / how to add a test but to my understanding, there aren't tests for any property right?

Related issue: #121.

thomaseizinger commented 6 years ago

I have no idea why the travis build fails. It doesn't seem to be related to the changes I made. Could anyone investigate this? @rkh @BanzaiMan ?

thomaseizinger commented 6 years ago

Ok, I was able to fix the issue by updating bundler as described here: https://github.com/jackc/tod/issues/36 :)

thomaseizinger commented 4 years ago

Closing this because I got no response.