travisbrady / py-soft-impute

Python implementation of Mazumder and Hastie's softImpute for matrix completion
44 stars 11 forks source link

definition of clf, and transform #1

Open subhareng opened 6 years ago

subhareng commented 6 years ago

Hi there, I just tried to add this package and was running into a couple issues. the first is when I try and run the test case in the readme.

screen shot 2018-07-05 at 3 49 35 pm

I looked at the main and found this line which defines the clf. I define the clf using the line in the main and then I get this error

screen shot 2018-07-05 at 4 23 15 pm
YasminFathy commented 4 years ago

I think you should use clf.predict(X), there is no transform method. Have a look at the example here: https://github.com/travisbrady/py-soft-impute/blob/4095a31146e4c0d28a4485865c37af7cad3dd6ce/soft_impute.py#L105