search

travisbrown / memory.lol

memory.lol
Other
423 stars 30 forks source link

added a v2 manifest for Firefox support #5

Closed naresh97 closed 1 year ago

naresh97 commented 1 year ago

Firefox seems to currently only support Manifest v2.

Tested working on Firefox 102.0.1 (64-bit) on Windows 10

Testing: remove (the v3) manifest.json and rename manifest_v2.json to manifest.json, then zip all the contents with the extension .xpi. Add-on can temporarily be loaded in about:debugging

travisbrown commented 1 year ago

Thank you—I will take a closer look and merge this today (as I've said, browser extension development isn't something I'm very familiar with). I assume the use of the chrome.runtime API will also need to be changed for Firefox?

Also, could you confirm that you're willing to have this contribution licensed both under the current license and possibly under the MPL in the future?

naresh97 commented 1 year ago

I don't do much extension development either tbh, just recently contributed to another extension I use. The chrome namespace doesn't need to be changed, as firefox implements it.

the current license is dope! agree to both licenses.

travisbrown commented 1 year ago

Great, thanks again!