search

traviscross / mtr

Official repository for mtr, a network diagnostic tool
http://www.bitwizard.nl/mtr/
GNU General Public License v2.0
2.68k stars 340 forks source link

MPLS display broken in head #370

Closed totoCZ closed 3 years ago

totoCZ commented 4 years ago

MPLS labels do not get printed out due to bugs in https://github.com/traviscross/mtr/commit/d2552ca9f65b1508805c4519bc7c02af2a810ff5#diff-bb7bdb248cc307bc78bed07a6d3a45c7R256

[root@ /home/tomas.hetmer/mtr/mtr]# git bisect bad d2552ca9f65b1508805c4519bc7c02af2a810ff5 is the first bad commit commit d2552ca9f65b1508805c4519bc7c02af2a810ff5 Author: atibdialpad matibuddin@dialpad.com Date: Sun Aug 23 20:41:27 2020 +0530

Change TTL dynamically to adjust for path changes

:040000 040000 e4bc3536316b73d95986c98b086bc82dd40add4d 47e32c0b5695a1e4c94fec023616231f56035a7e M ui

totoCZ commented 4 years ago

Hmm. It's actually me who broke it.

rewolff commented 4 years ago

You mean it's a local change or... did you submit broken code in the past? Patches/pull requests appreciated especially when you know what to fix. :-) (in the case that a patch is still coming, I would recommend to leave this open).

totoCZ commented 4 years ago

No i did a wrong bisect at 3am. It's the thing I was working on with the rewritten sockets.

rewolff commented 4 years ago

OK. No problem.

totoCZ commented 4 years ago

So it's this one https://github.com/TomHetmer/mtr/commit/6dd38651100368dcd4d8c1d0f14264c951ff1c3a shuffled around in https://github.com/traviscross/mtr/commit/d2552ca9f65b1508805c4519bc7c02af2a810ff5#diff-bb7bdb248cc307bc78bed07a6d3a45c7R256

totoCZ commented 4 years ago

That whole commit is broken,

with -u multipath hosts jump up and down like crazy

vincentbernat commented 3 years ago

I am also running this problem and I am also bisecting it to #364. It's hard to understand what the code is doing.