search

traviscross / mtr

Official repository for mtr, a network diagnostic tool
http://www.bitwizard.nl/mtr/
GNU General Public License v2.0
2.68k stars 340 forks source link

Fixes to make it behave more like stable 0.87 #371

Closed totoCZ closed 1 month ago

totoCZ commented 4 years ago

I'm not certain about some things in deconstruct_unix (why (struct ICMPHeader *) (ip + 1) in handle_received_ip4_packet? It should be the same for both sockets.

But I don't have any more time/energy to work on improving it further.

rewolff commented 4 years ago

Revert "Change TTL dynamically to adjust for path changes" … You want to revert some "improvements" that others are working on. You need to provide a better argument than: "I don't like it". For example a case where it did something wrong, so that we can go forward towards "the best of both worlds".

totoCZ commented 4 years ago

Wrong, I don't need to provide anything.

Anyhow, you better read why it's broken.

because it breaks MPLS and hosts start jumping up and down in the interactive display

rewolff commented 4 years ago

OK. I don't know how to reproduce the problems you're seeing.

totoCZ commented 4 years ago

Easy, run mtr with -e, ie.

./mtr upc.cz -e

Passes through aorta.net with MPLS, no MPLS labels are displayed.

Run mtr with -u

./mtr upc.cz -u

Unlike versions before that commit multiple hosts on each line start jumping up and down instead of staying at the fixed place making it super hard to read.

acoul commented 3 years ago

FWIW, I have tested the above patches against mtr-0.94 (with & without the Revert "Change TTL dynamically to adjust for path changes") but issue https://github.com/traviscross/mtr/issues/232 is still present

totoCZ commented 1 month ago

patch has been merged https://github.com/traviscross/mtr/pull/484