traviscross / mtr

Official repository for mtr, a network diagnostic tool
http://www.bitwizard.nl/mtr/
GNU General Public License v2.0
2.64k stars 337 forks source link

Delete questionable loop at the beginning of csv_close() #455

Open elfring opened 1 year ago

elfring commented 1 year ago

I noticed the following loop in the implementation of the function “csv_close”.

    for (i = 0; i < MAXFLD; i++) {
        j = ctl->fld_index[ctl->fld_active[i]];
        if (j < 0)
            continue;
    }

💭 I find such a control flow not useful. Thus I suggest to remove it.