search

travisghansen / argo-cd-helmfile

Integration between argo-cd and helmfile
MIT License
213 stars 55 forks source link

update helmfile binary to v0.144.0 #16

Closed tpatrascu closed 2 years ago

travisghansen commented 2 years ago

I'm going to implement this as an env var. I really never intended for that to ever get used outside of development (meaning, I assumed in real deployments people would install the version of the binary they want using init containers) but I guess it is :D

tpatrascu commented 2 years ago

Hi,

Thanks for taking a look. For safety reasons, if the functionality exists then it needs to be kept up to date, otherwise in case of a configuration error, it could run your stuff with an older version and possibly break it in prod. Also the cache cleanup command only works on the latest version of helmfile.

Thanks!

travisghansen commented 2 years ago

I already committed an update where it defaults to the latest but can be controlled via env var https://github.com/travisghansen/argo-cd-helmfile/commit/e148a7ed56f37fca3d04990431801e609100735e

travisghansen commented 2 years ago

I would highly recommend injecting the specific version you want using an init container however.