search

travisghansen / argo-cd-helmfile

Integration between argo-cd and helmfile
MIT License
213 stars 55 forks source link

[OCI Helm repo compatability]: Add support for optional skip of passing versions of k8s and APIs from command line #53

Open GolubevV opened 7 months ago

GolubevV commented 7 months ago

In the current implementation, Helmfile is passing all supplied arguments and env varialbes down to Helm tool.

However, in the case of working with OCI repositories for Helm charts, helmfile performs explicit pull from OCI before render and does not support the extra args that are inherited like --kube-version or --api-verssions.

As a result, it fails with the error like Error: unknown flag: --kube-version

This PR allows to skip passing the K8s and API versions if corresponding ENV variable HELMFILE_PASS_VERSIONS is set to false. By default, if not explicitly specified, it will be set to true to be backward compatible with previous behaviour.

@travisghansen - please tell. if you think we should consider to include this parameter into discovery output thus making it globally visible.