travisghansen / external-auth-server

easy auth for reverse proxies
MIT License
330 stars 44 forks source link

add podLabels parameter #95

Closed t3mi closed 3 years ago

t3mi commented 3 years ago

Adds configuration of additional pod labels, like cost center.

travisghansen commented 3 years ago

Do you think we should pump the value through the tpl function to allow for dynamic content?

t3mi commented 3 years ago

I doubt that as this is only needed for pods. tpl functions are useful if you want to apply some common labels for all resources not limiting to podSpec.

travisghansen commented 3 years ago

Sure, I mean something like this (example from another project):

  {{- range .Values.controller.externalAttacher.args }}
  - {{ tpl . $root }}
  {{- end }}

That would allow (in this context) to do something like this:

arbitraryStuff:
  something: otherthing
podLabels:
  foo: bar-{{ .Release.Namespace }}
  bar: baz-{{ .Release.Namespace }}-{{ .Values.arbitraryStuff.something }}
t3mi commented 3 years ago

Sorry, I misunderstood you. Switched to use of tpl function.

travisghansen commented 3 years ago

Thanks for the contribution!