DHCP Count Stuck on 0 - Githubissues

travisghansen / hass-pfsense

pfSense integration with Home Assistant

187 stars 27 forks source link

DHCP Count Stuck on 0 #181

Closed remlei closed 6 months ago

remlei commented 8 months ago

HA Core 2024.1.2 pfSense 2.7.2

DHCP Count stuck to zero after pfsense version update probably due to major upcoming changes with deprecated ISC DHCP server in favor of KEA DHCP server.

To reproduce, simply update to latest version and set the DHCP server to KEA.

drRax commented 8 months ago

I have the same issue. It started today after updating pfSense Plus from 23.05 to 23.09.1, changing the DHCP server backend from ISC to KEA. I'm also running HA Core 2024.1.2.

Langelus commented 8 months ago

Noticed the same behavior, just commenting to follow 👍

vanimox commented 8 months ago

I as well changed from ISC to KEA and now report 0 clients within the Home Assistant integration.

Hurr1c4n3 commented 8 months ago

I have the same problem, only I also down/upgraded from 23.05.1 to 2.7.2 and changed from ISC to KEA.

wormuths commented 7 months ago

I am experiencing this as well. I am still using ISC and have NOT switched to KEA as of yet.

PFSense Plus 23.09.1-RELEASE

bscheutjens commented 7 months ago

Same issue. I'm on the latest version of pfSense CE (2.7.2 as of writing) and have NOT switched to KEA

uniqueuid commented 7 months ago

Same issue. I'm on the latest version of pfSense CE (2.7.2) using ISC. I switched to KEA but switched back to ISC because KEA does not handle DHCP Static Mappings (A nice little surprise for unwary travellers).

bscheutjens commented 7 months ago

I took a look at the code and might have a fix.

Disclaimer: This involves manually changing files. If you make an error, the integration might not start anymore

Take your file editor of choice (I use the add-on Studio Code Server)
Go to the following path: custom_components/pfsense
Open the file __init__.py

Go to lines 357 to 360. They should look like as follows:

                    if lease["online"] in ["active", "online"]:
                        lease_stats["online"] += 1
                    if lease["online"] in ["offline", "idle/offline", "idle"]:
                        lease_stats["idle_offline"] += 1

Change the first line to:

                    if lease["online"] in ["active", "active/online", "online"]:

The whole block should now look like this:

                    if lease["online"] in ["active", "active/online", "online"]:
                        lease_stats["online"] += 1
                    if lease["online"] in ["offline", "idle/offline", "idle"]:
                        lease_stats["idle_offline"] += 1

Restart Home Assistant

danleongjy commented 7 months ago

The fix proposed by bscheutjens above worked for me!

travisghansen commented 7 months ago

I merged a long time ago but never snapped a release. I've now released v0.6.3 with this and other minor updates. Let me know how it goes.

Hurr1c4n3 commented 7 months ago

I merged a long time ago but never snapped a release. I've now released v0.6.3 with this and other minor updates. Let me know how it goes.

It works for me.