travisghansen / kubernetes-pfsense-controller

Integrate Kubernetes and pfSense
Apache License 2.0
197 stars 22 forks source link

Added option to set kubernetes cluster hostname #11

Closed codedninja closed 3 years ago

travisghansen commented 3 years ago

This is an interesting issue. I think I’ll actually fix the bug in the underlying client code and then this will inherit the fix (after updating the dep).

codedninja commented 3 years ago

Was trying to deploy under a Rancher cluster and the hostname scheme is different than kubernetes.default.svc that is set in " kubernetes-client-php ". Rancher's service discovery scheme is following kubernetes.default.svc.cluster.local

travisghansen commented 3 years ago

That should still resolve. What’s the value of the env var in the pod?

travisghansen commented 3 years ago

This has been fixed in the underlying code now in v0.4.0 rendering this PR unnecessary. Try it out and let me know if you run into any issues.