search

travisgoodspeed / goodwatch

Replacement board for Casio Calculator Watches using the CC430F6147
503 stars 55 forks source link

Fixed Alarm Inconsistencies #111

Closed BitBangingBytes closed 5 years ago

BitBangingBytes commented 5 years ago

I noticed some inconsistencies when using the alarm. Programming the alarm sometimes resulted in it also being enabled and other times I would return to the clock and it would remove the + in the process that had indicated it was enabled. This was fixed by moving the code from default: into the case 4: statement so upon last button press the changes are made. As it was before if a keypad button was pressed after the last digit was entered, it worked as expected. If instead the sidebutton was pressed the it would wipe out the +.

I also noticed on some watches I programmed the alarm didn't work at all. I believe this this due to the RTCADAY and RTCADOW not being initialized to 0 (which fixed the problem for me). Perhaps bit 7 was set on one of these leading the alarm to only be functional on a certain day.

travisgoodspeed commented 5 years ago

Thanks for another PR!

Some of the build artifacts from the user's guide snuck into this PR. guide.aux, guide.log, and guide.pdf should be cut before we merge.

BitBangingBytes commented 5 years ago

Apologies for the sketchy pull requests, currently watching YouTube videos on using Git and reading Pro Git to remedy this...

travisgoodspeed commented 5 years ago

Looks good! Merging.