search

travisgoodspeed / goodwatch

Replacement board for Casio Calculator Watches using the CC430F6147
502 stars 55 forks source link

start to convert goodwatch.py to python3 for #131 #132

Open tahnok opened 4 years ago

tahnok commented 4 years ago

I don't have a goodwatch to test this with, but python parses it without complaint

travisgoodspeed commented 4 years ago

Thanks for the PR, and email me your shipping address if you'd like to PCBs shipped your way.

This PR takes care of the print() difference, but python3-serial cannot accept strings for transactions. Instead it requires bytes, so the code fails when attempting to do transactions.

travisgoodspeed commented 4 years ago

We could merge this if the first line kept the parser as python2, as it helps toward compatibility but doesn't quite provide it. 98a04fae0489125e0039e835df8771496dfefb47 used that strategy.

tahnok commented 4 years ago

Thank you for the PCB offer, but I have an order in to a fab already.

I've updated to keep the parser as python2 which should make a second PR to use bytes instead of strings easier to look over