Rotation Matrix for Alignment

travisgoodspeed / maskromtool

A CAD tool for extracting bits from Mask ROM photographs.

Other

339 stars 21 forks source link

Rotation Matrix for Alignment #120

Open travisgoodspeed opened 3 months ago

travisgoodspeed commented 3 months ago

RomAlignerReliable now reliably aligns bits when the image is straight or reasonably tilted, but it becomes confused when a large gap exists between two sides of the ROM.

One method would be to calculate the tilt of the image from the 1st and n'th bits, then to do all comparisons from coordinates tilted in the same way.

[x] RomAlignerReliable forked into RomAlignerTilting
[x] Tilt detected.
[x] Rotation applied to coordinates.
[ ] Rotation aligner becomes default.

travisgoodspeed commented 3 months ago

This aligner is now supported. See Edit / Alignment Constraints / Strategy.

travisgoodspeed commented 3 months ago

All integration tests pass when making this the default and removing RomAlignerReliable, but at the cost of ~10% of execution time. For now, I'm holding off on making it the default.