search

travisgoodspeed / md380tools

Firmware patches for the TYT-MD380 handheld radio.
804 stars 244 forks source link

Red Button Menue changing Zone - GPS Version not stored #763

Closed DL9SK closed 7 years ago

DL9SK commented 7 years ago

Version 2017-05-20 bc3586b GPS MD390

When changing the zone with/up down button in the red button menue it will not be stored after leaving the menue. This happens only with the gps version. I have both MD-390 version with and without gps here. The non gps version works correct. Zone was stored after leaving red button menue. Ii would be great if it will be fixed.

Wolf-DL4YHF commented 7 years ago

Hi Ralf,

I would have implemented that myself, but I have no GPS to find out the addresses where the GPS-variant stores the zone information (in RAM, since the zone-number is not stored immediately in Flash by the "red button menu" yet). I can make a guess by looking at the disassembly, but it's an extremely tedious and time-consuming effort. If anyone with a GPS-radio can find or check that address, I can quickly add them in the firmware for your radio. In the non-GPS variant, I already found the address (and added it as a symbol in codeplug.h) : CODEPLUG_RAM_ADDR_ZONE_NUMBER_STRUCT = 0x2001E57C .

For the GPS variant, the address will be similar but not necessarily the same. If you think you know it, you can watch the address in the tiny hexadecimal viewer:

The hex monitor shows a few hundred bytes, frequently updated. The current zone number is the fourth byte of a five-byte structure, most of them will show "FF" (don't ask me why, ask Tytera..) so it's quite easy to find. Try a few different zones in the original Tytera menu, and if the hex monitor always shows the expected value - bingo, got it.

The same principle can be used to find other items in RAM, CPU-Flash, or SPI-Flash too. But that's OT here, one day I will properly document the hex monitor..

Cheers, Wolf DL4YHF .

Am 22.05.2017 um 16:39 schrieb Ralf:

Version 2017-05-20 bc3586b https://github.com/travisgoodspeed/md380tools/commit/bc3586b22cca70da40f88ea9d2f6059a3ede0084 GPS MD390

When changing the zone with/up down button in the red button menue it will not be stored after leaving the menue. This happens only with the gps version. I have both MD-390 version with and without gps here. The non gps version works correct. Zone was stored after leaving red button menue. Ii would be great if it will be fixed.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/travisgoodspeed/md380tools/issues/763, or mute the thread https://github.com/notifications/unsubscribe-auth/AXwwfWLI1E7G0pBsVHMkD3Az7gInMPq_ks5r8Z4-gaJpZM4Nic3g.

DL9SK commented 7 years ago

Hi Wolf,

I checked it. It should be 2001E643

73 Ralf DL9SK

DL9SK commented 7 years ago

Here the screenshot md390gps

Wolf-DL4YHF commented 7 years ago

Hi Ralf,

Many thanks - if the currently active zone was number 7 when you made the screenshot, the start address of the "five-byte-struct" would be at 2001E64C : Three bytes with FF, then the zone number, followed by a fourth FF. As expected, the data are as in the non-GPS firmware (where the structure begins at 2001E57C), only the address is different. The address difference (0x00D0) also sounds plausible.

I will have a look at this tomorrow; maybe we simply try with a preliminary firmware for the GPS radio that I can upload to my website (binary file for downloading with the Tytera firmware updater, or with the md380-tools).

73, Wolf DL4YHF .

Am 23.05.2017 um 11:19 schrieb Ralf:

Hi Wolf,

I checked it. It should be 2001E643

I send you the Hex Screenshots per Mail

73 Ralf DL9SK

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/travisgoodspeed/md380tools/issues/763#issuecomment-303340904, or mute the thread https://github.com/notifications/unsubscribe-auth/AXwwfTEqq5y3IMFfl-2FQtxB3JC-pTlGks5r8qSwgaJpZM4Nic3g.

Jumbotroll commented 7 years ago

Tested on MD390 GPS and the Zone is now stored. Great job!

Wolf-DL4YHF commented 7 years ago

Thanks for testing, and again to Ralf for searching and finding the address. Going to merge these three new lines of code, since they won't do harm. The Travis CI server seems to be working again, all tests passed (also with the clang compiler).

Cheers and good night from Germany, Wolf DL4YHF .

Am 23.05.2017 um 23:56 schrieb Jumbotroll:

Tested on MD390 GPS and the Zone is now stored. Great job!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/travisgoodspeed/md380tools/issues/763#issuecomment-303544053, or mute the thread https://github.com/notifications/unsubscribe-auth/AXwwfdVbW5fjkrgD4YFnC5PjM3vtdO0kks5r81YDgaJpZM4Nic3g.

DL9SK commented 7 years ago

Now it works perfect. Many thanks for fast fixing to Wolf.

73 Ralf DL9SK