travisgoodspeed / md380tools

Firmware patches for the TYT-MD380 handheld radio.
804 stars 244 forks source link

Advanced statusline, sidebutton extension, display RX/TX freq from CP #821

Closed DL2MF closed 6 years ago

DL2MF commented 7 years ago

This PR is providing all latest changes:

travisgoodspeed commented 7 years ago

Looks like a few warnings need to be cleaned up before merging.

arm-none-eabi-gcc -std=gnu99 -g -O2 -Wall -Tapplet_d02.032.ld -mlittle-endian -mthumb -mcpu=cortex-m4 -mthumb-interwork -mfloat-abi=hard -mfpu=fpv4-sp-d16 -fshort-wchar -Wa,-a=amenu_channels.lst -DFW_D02_032  -Werror -Wno-cpp -Iinc -Ilib -Ilib/inc -I. -Ilib/inc/core -Ilib/inc/peripherals -D "MD380_d02_032"     -c -o amenu_channels.o src/amenu_channels.c
src/amenu_channels.c: In function 'readTone':
src/amenu_channels.c:148:2: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
  if (*(uint16_t*)&chan->settings[(fEnc ? 26 : 24)] == 0xFFFF) {
  ^
src/amenu_channels.c: In function 'ParseChannel':
src/amenu_channels.c:228:1: error: control reaches end of non-void function [-Werror=return-type]
 }
 ^
cc1: all warnings being treated as errors
make[3]: *** [amenu_channels.o] Error 1
make[3]: Leaving directory `/home/travis/build/travisgoodspeed/md380tools/applet'
make[2]: *** [image_D02] Error 2
make[2]: Leaving directory `/home/travis/build/travisgoodspeed/md380tools/applet'
make[1]: *** [ci] Error 2
make[1]: Leaving directory `/home/travis/build/travisgoodspeed/md380tools/applet'
make: *** [ci] Error 2
The command "bash -x ci-script.sh" exited with 2.
Done. Your build exited with 1.
DL2MF commented 7 years ago

Worked today on compatibility to D02 firmware, will check the differences of warnings to my local compiler results.

travisgoodspeed commented 7 years ago

Run make ci to do the same sort of build that the CI server does. I think it's stricter about warnings, treating some of them as errors.

DL2MF commented 7 years ago

Still working on this, fixed some warnings but a few still remaining. Todo for this weekend.

stefansaraev commented 6 years ago

fyi I have rebased this PR on top of master and made "make ci" happy (I dont pretend I've done it right) at https://github.com/stefansaraev/md380tools/tree/pr821-rebase

the whole thing needs a bit of cleanup, and I've noticed some annoyances but IMO this feature is good enough to go into master (tbh, I cant test the sms thing, but extended display and sidebutton functions are nice!)

feel free to continue from here if it helps

DL2MF commented 6 years ago

Tnx @stefansaraev for working on the cleanup. Finally found some time during the last week to fix the latest compiler warnings and test this build. @travisgoodspeed should be fine now to me merged.

travisgoodspeed commented 6 years ago

Thanks, @stefansaraev and @DL2MF! Merging this now.

73 from Reno, --Travis KK4VCZ