travisgoodspeed / md380tools

Python tools and patched firmware for the TYT-MD380
803 stars 245 forks source link

fix talker alias decode issue #908

Closed shawnchain closed 4 years ago

shawnchain commented 4 years ago

I refined the FULL_LC handling logic inside 'radiostate.c' to completely fix the talker alias decode issue.

Before Fix: TA will only display the 2nd time call occurs from the same src, and always sticks to the same source.

After Fix: The TA will be decoded (once) for each call conversation and displayed right after the call terminated.

The mess of call start check is untouched, but could be easily refactored after my patch.

ghost commented 4 years ago

I admit I haven't tested, myself, but it looks nice and clean.

ghost commented 4 years ago

Thank you!

shawnchain commented 4 years ago

I have tested with MD380 and Hytera PD980. It will print received ta blocks in netmon3 and TA in netmon4.

One issue is left, Need to find a way to update/invalidate the BLUE RX POPUP to reflect the decoded TA on the fly, but currently no luck.

ghost commented 4 years ago

Loving these patches. My current job makes contributing directly very difficult, but I am happy to merge and help test as much as I can!