search

travisgoodspeed / md380tools

Python tools and patched firmware for the TYT-MD380
803 stars 245 forks source link

encryption #929

Closed jimgillo closed 3 years ago

jimgillo commented 3 years ago

Hello Travis, You say in the aes.file /* The key has more than its least-significant byte set, so we'll use the original Tytera algorithm. At some point, it might make sense to replace this with proper crypto, rather than XOR.

1-Why don't you modify the code to use better crypto? 2-If you don't want to modify the code, could you add an hook to access to the code where the AES 49 bits stream is XOR'ed with the audio?

For example if i want to use AES in CFB or CBC mode i must modify the code where the AES stream is XOR'ed with the audio, but there is no such hook in the MD3800 tools.

travisgoodspeed commented 3 years ago

Enough hooks should be available to add better crypto, but I'm busy with other projects and won't be implementing it myself.