travisjeffery / jocko

Kafka implemented in Golang with built-in coordination (No ZK dep, single binary install, Cloud Native)
https://twitter.com/travisjeffery
MIT License
4.92k stars 361 forks source link

Protocol Constants #156

Closed pascaldekloe closed 1 year ago

pascaldekloe commented 5 years ago

Fixes protocol.CoordinatorTransaction value plus error simplification.

canesin commented 4 years ago

@pascaldekloe where you did you find that the CoordinatorTransaction has CoordinatorType = 1 ? I couldn't find the source in the protocol page.

pascaldekloe commented 4 years ago

Can you add a little context? I wrote this 8 months ago. 😏

travisjeffery commented 4 years ago

I'd be down for updating protocol.CoordinatorTransaction but I'm not a fan of the rest of the API changes.