search

travisjeffery / timecop

A gem providing "time travel", "time freezing", and "time acceleration" capabilities, making it simple to test time-dependent code. It provides a unified method to mock Time.now, Date.today, and DateTime.now in a single call.
MIT License
3.36k stars 223 forks source link

Explicitly require activesupport >= 4.2 #391

Closed mishina2228 closed 1 year ago

mishina2228 commented 1 year ago

The scheduled CI with Ruby 2.3, 2.4 and 2.5 fails these days. (e.g. https://github.com/travisjeffery/timecop/actions/runs/3120487421)

I couldn't fully figure out the root cause, but it appears to be caused by the installation of activesupport v3.1.12. Requiring activesupport v4.2 or higher solved this problem.

mishina2228 commented 1 year ago

Perhaps #383 and #384 are also related? All tests succeed on my fork, including Ruby 2.5. https://github.com/mishina2228/timecop/actions/runs/3126859082/jobs/5072836151

I'm not a professional of this issue, but looking at https://github.com/travisjeffery/timecop/issues/383#issuecomment-1179751991 I thought it might be due to the gem cache. In that case, I hope that this PR will update the gem dependencies so that the cache will be rebuilt and the problem will go away.

joshuacronemeyer commented 1 year ago

ok 2.5 is failing right now. I'll merge this. If the build passes we'll keep this.

joshuacronemeyer commented 1 year ago

This didn't work. I reverted.

mishina2228 commented 1 year ago

hmm... no problem with my fork... I'll try to dig into this issue more.

mishina2228 commented 1 year ago

OK, maybe I found something useful. https://github.com/ruby/setup-ruby#dealing-with-a-corrupted-cache I will create a new PR.