[BUG/FEATURE] Parse day name with hour

travisjeffery / timecop

A gem providing "time travel", "time freezing", and "time acceleration" capabilities, making it simple to test time-dependent code. It provides a unified method to mock Time.now, Date.today, and DateTime.now in a single call.

MIT License

3.36k stars 223 forks source link

[BUG/FEATURE] Parse day name with hour #417

Closed ptrela closed 3 months ago

ptrela commented 5 months ago

DateTime.parse("Wednesday 13:00") returns midnight hour.

More explanation here: https://github.com/travisjeffery/timecop/issues/418

joshuacronemeyer commented 3 months ago

This is good. Thank you. I'm approving/merging. While i was thinking about this one I thought of another scenario we do not handle. I filed the bug here https://github.com/travisjeffery/timecop/issues/422 if you're interested you could fix it too. It will be very similar. Thanks again.