search

travisjeffery / timecop

A gem providing "time travel", "time freezing", and "time acceleration" capabilities, making it simple to test time-dependent code. It provides a unified method to mock Time.now, Date.today, and DateTime.now in a single call.
MIT License
3.37k stars 226 forks source link

Require Ruby >= 2.1.0 #423

Closed alexcwatt closed 2 months ago

alexcwatt commented 4 months ago

https://github.com/travisjeffery/timecop/pull/419 had to check for Ruby >= 2.1.0, but maybe this is a good time to bump the Ruby version in the library and cut a release?

(I also noticed CI seems to test back to 2.3, so maybe we consider going up even further.)

joshuacronemeyer commented 4 months ago

thanks @alexcwatt I support this. I didn't realize u had made this PR and I just did a release without this. Let's let this marinate here for a week or so and if nobody comes out of the woodwork we'll do this..

joshuacronemeyer commented 2 months ago

@alexcwatt any chance you can resolve these conflicts. Sorry. I'm hoping to put together a release soon and would like to include this.

alexcwatt commented 2 months ago

@joshuacronemeyer updated and looks like CI passed! This one might be easier to review with whitespace hidden.