search

travisjungroth / formlessness

A Python library for making web forms on the back end
MIT License
5 stars 2 forks source link

Fix \w doctest error #177

Closed natashavinik closed 2 years ago

natashavinik commented 2 years ago

In constraints.py, in class Regex, I changed the docstring tests so they dont throw up warnings anymore.

codecov[bot] commented 2 years ago

Codecov Report

Merging #177 (b4786c2) into main (9663612) will decrease coverage by 0.21%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #177      +/-   ##
==========================================
- Coverage   91.00%   90.78%   -0.22%     
==========================================
  Files          15       15              
  Lines        1145     1140       -5     
  Branches      152      152              
==========================================
- Hits         1042     1035       -7     
- Misses         86       88       +2     
  Partials       17       17
Impacted Files Coverage Δ
tests/test_constraints.py 90.90% <ø> (-3.54%) :arrow_down:
formlessness/constraints.py 86.02% <100.00%> (-0.42%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9663612...b4786c2. Read the comment docs.

travisjungroth commented 2 years ago

I'm still seeing warnings in the test logs, although different ones. When you run pytest in the command line it should be all green (no yellow warnings). I think it might work to change the docstring back to a raw string (leading r) and change the slashes to double slashes.

travisjungroth commented 2 years ago

pytest -W error will make the failures more clear.

natashavinik commented 2 years ago

Interesting, i'm not getting any failures on my end - it's all green. Have a meeting in a bit but i'll check out what's going on later!

On Wed, Jun 29, 2022 at 11:35 AM Travis Jungroth @.***> wrote:

pytest -W error will make the failures more clear.

— Reply to this email directly, view it on GitHub https://github.com/travisjungroth/formlessness/pull/177#issuecomment-1170354617, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXU4I4NWZPCJ3XWSGJTU7FLVRSJQTANCNFSM52GVF5WQ . You are receiving this because you authored the thread.Message ID: @.***>