codepathreview
commented
7 years ago :+1: Great work overall! A few notes after checking out the assignment:
- Properly reused the single base method in search activity to fetch results for both initial load and the pagination
- Nice to see you added the search box to the
ActionBar! - Properly used spinners & check-boxes (with populated values) to allow users to select appropriate values.
- Properly sent and received relevant filters using a bundle to pass data between activities
- Good to see you used a filters object to represent the filters to apply to the query
- Nice job adding the share intent to the article detail view!
- Consider adding progress bars to your app whenever a network request goes out
Also, here's a more detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.
Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.
please review my assignment /cc @codepathreview @codepath