search

travist / jsencrypt

A zero-dependency Javascript library to perform OpenSSL RSA Encryption, Decryption, and Key Generation.
http://www.travistidwell.com/jsencrypt
Other
6.69k stars 2.02k forks source link

Other Algorithms (ECC) #23

Open tuaris opened 10 years ago

tuaris commented 10 years ago

I think this library is what I need, but I was wondering if it also supports ECC?

zoloft commented 10 years ago

While this is pretty easy to do, (thankfully Tom Wu provided an ECC implementation) I am not sure it will fit in this library since the primary aim of JSEncrypt was to give a library that is fully compatible with the RSA keys provided by openssl. Anyway since openssl provides an ECC implementation we could extend the library to support it. Before doing anything I'll wait for @travist 's opinion.

travist commented 10 years ago

I have no problems at all supporting other implementations that OpenSSL also supports. As long as the interface is clean and intuitive, I will happily accept a pull request for this feature. Thanks @zoloft for your help.

zoloft commented 10 years ago

At this point @travist I think I'll fork Tom Wu's work in a repository to fix also the global pollution that makes the tests fail under specific circumstances and reference it instead of the original one. This way you can close #12

travist commented 10 years ago

Sounds great. I look forward to what you come up with. Make sure you rebase local repo since I recently moved some files around and did some cleanup.

travist commented 10 years ago

@zoloft, I just made you a Contributor (admin) of this repo so you should be able to push any updates and merge any changes to this repository. Thanks again for your help.

zoloft commented 10 years ago

Thank you @travist, I'll add an ECC branch that i'll keep synchronized with my master branch. For now I'm just preparing, but soon i'll start on the real implementation

zoloft commented 10 years ago

Sorry if it is taking this much guys but I'm on a tight schedule at work. Anyway I started documenting about ECC and analysing the structures so that as soon as possible I can actually start writing code&tests.

Progress on this feature start from commit 8f51c1375c

zoloft commented 10 years ago

@travist I'd appreciate a feedback about the changes I made to the Gruntfile and to the source code, if it is everything right or I should change something. I changed the way the keys are generated asynchronously using workers (much more performant than the nested loops used now)