search

travitch / build-bom

Dynamically discover the commands used to create a piece of software
Apache License 2.0
45 stars 8 forks source link

Use objcopy instead of objdump to check for pre-existing section. #66

Closed kquick closed 4 months ago

kquick commented 4 months ago

If cross-compilation is being performed, the build-bom process needs to use tools compatible with the cross-compilation ELF format. Prior to this change, it accepts a cmdline override for the objcopy tool to use, but was still using the standard objdump tool (to check if the llvm-bitcode section was already present in the ELF file). This change modifies it to use that same objcopy rather than objdump to perform the test. The alternative would be to allow/require the user to be able to override the objdump tool; this approach was chosen in favor of user simplicity.

kquick commented 4 months ago

Any concerns with this PR?

travitch commented 4 months ago

No, just behind on reading the longer one