travitch / persistent-vector

Persistent vectors for Haskell based on array mapped tries
BSD 3-Clause "New" or "Revised" License
27 stars 4 forks source link

Doesn't build on GHC 7.10 with recent dependencies #1

Closed radix closed 9 years ago

radix commented 9 years ago

Trying to build persistent-vector gives me this:

src/Data/Vector/Persistent/Array.hs:55:7:
    Ambiguous occurrence ‘traverse’
    It could refer to either ‘Data.Vector.Persistent.Array.traverse’,
                             defined at src/Data/Vector/Persistent/Array.hs:465:1
                          or ‘P.traverse’,
                             imported from ‘Prelude’ at src/Data/Vector/Persistent/Array.hs:67:1-56
                             (and originally defined in ‘Data.Traversable’)

Hacking around that problem (in a way I'm not sure is backwards compatible), I then get this trying to build the benchmark:

bench/pvBench.hs:3:8:
    Could not find module ‘Criterion.Config’
    Perhaps you meant
      Criterion.Monad (from criterion-1.1.0.0@crite_IAvDJexKd482tiz7RXZaU5)
    Use -v to see a list of the files searched for.

after simply deleting that import we run into a real incompatibility with Criterion's defaultMainWith -- apparently they got rid of the preparation (:: Criterion ()) argument. I don't know anything about criterion so I'm not sure how to fix this one.

travitch commented 9 years ago

Thanks for the report - I'll fix that shortly

travitch commented 9 years ago

Should be fixed in 9d14c6ba3f5e3601c00 and version 0.1.1 on hackage

radix commented 9 years ago

Thanks @travitch! :sunglasses: