Upgrade packages / Use mdpdf >=2.0.0 (puppeteer)

travs / markdown-pdf

Convert markdown to pdf, png or jpeg on the fly in Atom

MIT License

263 stars 44 forks source link

Upgrade packages / Use mdpdf >=2.0.0 (puppeteer) #219

Closed jooola closed 4 years ago

jooola commented 5 years ago

Since phantomJS has been deprecated, we should upgrade the mdpdf package that now uses puppeteer to generate pdf files.

This will probably fix a lot a past issues without much effort.

Also I suggest to drop the fallback code that is getting more and more buggy since the dependencies aren't updated anymore.

I hope we can get this merged in no time !

elliotblackburn commented 5 years ago

2.0.5 now supports the sandbox changes proposed by @jooola, so moving to this version would be a better idea 😄

jooola commented 5 years ago

@BlueHatbRit Thanks for this ! Hope we can get this merged PR merged soon. Is @travs away ?

elliotblackburn commented 5 years ago

I don't know, I don't work with Travs, we just collaborate on this and mdpdf 😄. I'm sure he'll seen this soon enough and will be able to give it a look

jooola commented 4 years ago

Ping @travs

travs commented 4 years ago

Pushed with a couple fixes and released in v2.3.0