Conversion fails with `Error: ENOENT: ...`

Moghi commented 4 years ago

Prerequisites

[ ] Reproduced the problem in Safe Mode (may not be approriate if your error involves markdown-preview-plus): http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
[x] Checked that the issue isn't already filed: https://github.com/travs/markdown-pdf/issues)

Issue description

Conversion fails with error:

markdown-pdf.js? [sm]:135 Error: ENOENT: no such file or directory, open '/home/myCompany.org/myUser/.atom/styles.less'
    at Object.openSync (fs.js:436)
    at Object.module.(anonymous function) [as openSync] (ELECTRON_ASAR.js:160:31)
    at Object.readFileSync (fs.js:341)
    at Object.fs.readFileSync (ELECTRON_ASAR.js:580)
    at HTMLElement.<anonymous> (markdown-pdf.js? [sm]:118)
    at Generator.next (<anonymous>)
    at step (/home/myCompany.org/myUser/.atom/packages/markdown-pdf/lib/markdown-pdf.js:1)
    at /home/myCompany.org/myUser/.atom/packages/markdown-pdf/lib/markdown-pdf.js:1
    at new Promise (<anonymous>)
    at HTMLElement.<anonymous> (/home/myCompany.org/myUser/.atom/packages/markdown-pdf/lib/markdown-pdf.js:1)
    at CommandRegistry.handleCommandEvent (/usr/share/atom/resources/app/static/<embedded>:11)
    at CommandRegistry.dispatch (/usr/share/atom/resources/app/static/<embedded>:11)
    at AtomEnvironment.dispatchApplicationMenuCommand (/usr/share/atom/resources/app/static/<embedded>:1)
    at EventEmitter.t (/usr/share/atom/resources/app/static/<embedded>:1)
    at EventEmitter.emit (events.js:182)
(anonymous) @ markdown-pdf.js? [sm]:135
step @ /home/myCompany.org/myUser/.atom/packages/markdown-pdf/lib/markdown-pdf.js:1
(anonymous) @ /home/myCompany.org/myUser/.atom/packages/markdown-pdf/lib/markdown-pdf.js:1
(anonymous) @ /home/myCompany.org/myUser/.atom/packages/markdown-pdf/lib/markdown-pdf.js:1
handleCommandEvent @ <embedded>:11
dispatch @ <embedded>:11
dispatchApplicationMenuCommand @ <embedded>:1
t @ <embedded>:1
emit @ events.js:182
markdown-pdf.js? [sm]:157 TypeError: Cannot read property 'name' of undefined
    at Object.<anonymous> (fallback.js? [sm]:20)
    at Generator.next (<anonymous>)
    at step (fallback.js? [sm]:28)
    at fallback.js? [sm]:28
    at new Promise (<anonymous>)
    at Object.convert (fallback.js? [sm]:28)
    at HTMLElement.<anonymous> (markdown-pdf.js? [sm]:137)
    at Generator.next (<anonymous>)
    at step (/home/myCompany.org/myUser/.atom/packages/markdown-pdf/lib/markdown-pdf.js:1)
    at /home/myCompany.org/myUser/.atom/packages/markdown-pdf/lib/markdown-pdf.js:1
    at new Promise (<anonymous>)
    at HTMLElement.<anonymous> (/home/myCompany.org/myUser/.atom/packages/markdown-pdf/lib/markdown-pdf.js:1)
    at CommandRegistry.handleCommandEvent (/usr/share/atom/resources/app/static/<embedded>:11)
    at CommandRegistry.dispatch (/usr/share/atom/resources/app/static/<embedded>:11)
    at AtomEnvironment.dispatchApplicationMenuCommand (/usr/share/atom/resources/app/static/<embedded>:1)
    at EventEmitter.t (/usr/share/atom/resources/app/static/<embedded>:1)
    at EventEmitter.emit (events.js:182)
(anonymous) @ markdown-pdf.js? [sm]:157
(anonymous) @ markdown-pdf.js? [sm]:158
step @ /home/myCompany.org/myUser/.atom/packages/markdown-pdf/lib/markdown-pdf.js:1
Promise.then (async)
step @ /home/myCompany.org/myUser/.atom/packages/markdown-pdf/lib/markdown-pdf.js:1
(anonymous) @ /home/myCompany.org/myUser/.atom/packages/markdown-pdf/lib/markdown-pdf.js:1
(anonymous) @ /home/myCompany.org/myUser/.atom/packages/markdown-pdf/lib/markdown-pdf.js:1
handleCommandEvent @ <embedded>:11
dispatch @ <embedded>:11
dispatchApplicationMenuCommand @ <embedded>:1
t @ <embedded>:1
emit @ events.js:182

Steps to reproduce

Expected behavior: [What you expect to happen]

Open markdown file
Packages -> Markdown to PDF -> Convert
Create a pdf file, without an error

Actual behavior: [What actually happens] Fails with error.

Versions

You can get this information from copy and pasting the output of atom --version and apm --version from the command line. Also, please include the OS and what version of the OS you're running.

Atom : 1.43.0 Electron: 4.2.7 Chrome : 69.0.3497.128 Node : 10.11.0

apm 2.4.3 npm 6.2.0 node 10.2.1 x64 atom 1.43.0 python git 2.18.2

OS: Linux Centos 8

travs commented 4 years ago

@Moghi Hey, thanks for this. I am able to reproduce, and will push a fix shortly. I'm just wondering, did the fallback conversion kick in for you, or did you just get this error and no fallback conversion was attempted?

Moghi commented 4 years ago

Hi @travs, I think the fallback conversion did kick in, but I can't be sure since it has been a while now. sorry Thanks for the fix though!

travs / markdown-pdf