traxaber / cs435-p2

0 stars 0 forks source link

Code Review #3

Open William-Vigo opened 4 years ago

William-Vigo commented 4 years ago

https://github.com/angdav/cs435-p2/blob/7773ebbbc02f04d5968b58217efb4db4635591ad/p4.py#L91

im not to familiar with the random.sample method but based of what i searched around this can possible create cycles in your graph which a dag isn't supposed to have

traxaber commented 4 years ago

Addressed in: https://github.com/angdav/cs435-p2/commit/0f8931c20ae409797a1921173f8cf032231e54cc