search

trayio / babel-plugin-webpack-alias

babel 6 plugin which allows to use webpack resolve options
MIT License
150 stars 32 forks source link

feat(conf): Adds support for webpack configurations exported as functions #54

Closed BRKalow closed 5 years ago

BRKalow commented 7 years ago

Webpack configurations can be exported as functions, but this plugin wasn't handling that. I've added a check within the plugin to invoke conf if it is of type function. (fixes #47)

I also renamed webpack.multicompile.js to webpack.multicompile.config.js so the eslint ignore comments could be removed.

Thanks!

codecov-io commented 7 years ago

Codecov Report

Merging #54 into master will increase coverage by 0.12%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #54      +/-   ##
=========================================
+ Coverage   94.38%   94.5%   +0.12%     
=========================================
  Files           1       1              
  Lines          89      91       +2     
=========================================
+ Hits           84      86       +2     
  Misses          5       5
Impacted Files Coverage Δ
src/index.js 94.5% <100%> (+0.12%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cb486b7...1fd34aa. Read the comment docs.

gixo commented 5 years ago

I am closing this pull request due to inactivity. Let me know if needs to be reopened. @BRKalow @aychtang