GH18: Add support for fixture test output to message sink

trbenning / serilog-sinks-xunit

The xunit test output sink for Serilog

MIT License

80 stars 7 forks source link

GH18: Add support for fixture test output to message sink #19

Closed gitfool closed 4 years ago

gitfool commented 4 years ago

Fixes #18.

gitfool commented 4 years ago

@trbenning please review. I'm using a local fork but would love to merge here, if you're interested. 😉

trbenning commented 4 years ago

Sorry, about the delay. I saw this come in, then all hell broke loose with the virus, and it slipped my mind. I'll give it a look tonight.

Thanks for the reminder.

gitfool commented 4 years ago

I noticed the whitespace was inconsistent so I ran the source through Resharper Code Cleanup. I can hard reset and force push to remove that commit if you don't like it.

gitfool commented 4 years ago

Finally, if you run the Serilog.Sinks.XUnit.Tests project with Resharper then xUnit fixture test output to message sink appears in popup window. I just discovered that's because it targets the net461 framework. Remove that and the popup goes away. I presume that's a bug in Resharper, so just a heads up.