trbenning / serilog-sinks-xunit

The xunit test output sink for Serilog
MIT License
83 stars 8 forks source link

GH24: Update default console output template #26

Closed gitfool closed 2 years ago

gitfool commented 3 years ago

Fixes #24. Also:

@trbenning I thought this was a good time to throw in some other maintenance - dropping unsupported target frameworks and bumping dependencies - so I also bumped the major version accordingly. Finally, AFAICT the AppVeyor build has rotted since it refers to a non-existent file, so I removed it to avoid confusion as the deterministic build is tied to a particular build server; Azure Pipelines in this case.

gitfool commented 3 years ago

@trbenning Hopefully I didn't scare you off with all the extra changes I threw in. Happy to discuss and prune if required. 😉

gitfool commented 2 years ago

@trbenning thoughts?

trbenning commented 2 years ago

@gitfool, sorry, I'm not sure how I missed the update notifications. I haven't used this package in a while, and haven't revisited it in quite a while. The changes you made all look good to me, so I'll go ahead and approve this PR.

Thanks for putting it together!

gitfool commented 2 years ago

@trbenning don't forget to publish the NuGet package (and symbols). 🙄

trbenning commented 2 years ago

It was published a while ago, but it's taking a while to be validated. I assume it will be available in a few hours.