Fix packaging issues, to improve situation downstream

trbs / pid

Pidfile featuring stale detection and file-locking, can also be used as context-manager or decorator

https://pypi.python.org/pypi/pid/

Apache License 2.0

102 stars 26 forks source link

Fix packaging issues, to improve situation downstream #19

Closed thnee closed 5 years ago

thnee commented 5 years ago

These are improvements that will help when building downstream packages. Specifically, I am maintaining the FreeBSD port: https://www.freshports.org/devel/py-pid

Add tests directory to MANIFEST.in, so that tests can be run when building the port.
Put nose requirement in tests_require rather than setup_requires, to avoid confusion. The setup_requires category is only for custom setup scripts, not for test dependencies. (See https://setuptools.readthedocs.io/en/latest/setuptools.html for reference).

Hope this makes sense! =)

coveralls commented 5 years ago

Coverage remained the same at 94.611% when pulling e0d4d2e7fbadf45fc0591b6aeb44659d8d58a780 on thnee:fix_packaging into 26f511baf1ea7c607861f01e5e9a4a5a036c21e4 on trbs:master.

coveralls commented 5 years ago

Coverage remained the same at 94.611% when pulling 1b133c3da321e6ed8850b410687c93e20b66ed4b on thnee:fix_packaging into 26f511baf1ea7c607861f01e5e9a4a5a036c21e4 on trbs:master.

trbs commented 5 years ago

Thanks !

trbs commented 5 years ago

(Released v2.2.1)

thnee commented 5 years ago

Thank you for the fast response, and for making a release! However, it looks like the test_pid.test_pid_check_samepid_two_processes test is not working on FreeBSD, not sure why yet.