Fix some issues in a test case

trbs / pid

Pidfile featuring stale detection and file-locking, can also be used as context-manager or decorator

https://pypi.python.org/pypi/pid/

Apache License 2.0

102 stars 26 forks source link

Fix some issues in a test case #21

Closed thnee closed 5 years ago

thnee commented 5 years ago

Fixes #20

Tested it on Linux, FreeBSD native, and FreeBSD jail, works as expected.

thnee commented 5 years ago

The tests are failing because of something unrelated. It has problems download python source from AWS S3. I don't think I can restart the job, since it is not my repo. Can you maybe restart it @trbs?

coveralls commented 5 years ago

Coverage decreased (-1.2%) to 93.413% when pulling edd07d29656cbda5742b7b03be4bf8b9020c9e89 on thnee:fix_test_issues into d1d70ec2368fd9c1ad112c58d8fca2edebc68d8c on trbs:master.

coveralls commented 5 years ago

Coverage decreased (-1.2%) to 93.413% when pulling edd07d29656cbda5742b7b03be4bf8b9020c9e89 on thnee:fix_test_issues into d1d70ec2368fd9c1ad112c58d8fca2edebc68d8c on trbs:master.

thnee commented 5 years ago

Hmm, maybe not optimal that I am decreasing the test coverage. Will look into that.

trbs commented 5 years ago

The tests are failing because of something unrelated. It has problems download python source from AWS S3. I don't think I can restart the job, since it is not my repo. Can you maybe restart it @trbs?

restarted :-)

thnee commented 5 years ago

Thanks for the quick reactions! May I ask for a new release to pypi also? Since that is the master site used in the FreeBSD port.

trbs commented 5 years ago

@thnee https://pypi.org/project/pid/2.2.2/ 🎉

thnee commented 5 years ago

Brilliant, thanks! :cake: