treadmill-tb / treadmill

The Treadmill Hardware Testbed Software Stack
Apache License 2.0
2 stars 0 forks source link

connector/ws: allow reading token from file in addition to config #43

Closed lschuermann closed 2 months ago

lschuermann commented 2 months ago

This makes it easier to exclude secrets from otherwise public configuration files.

lschuermann commented 2 months ago

I think this needs to also strip the string of all trailing and leading whitespace, such as newlines. Let me add this!

max-cura commented 2 months ago

LGTM.

max-cura commented 2 months ago

Belatedly, I'm realizing that this might have been a use case for figment and environment variables? (e.g. as in #18)