search

treagod / spectator

Client to test web endpoints
https://treagod.github.io/spectator/
GNU General Public License v3.0
78 stars 6 forks source link

Collection Rename doesn't work #33

Closed jdmg94 closed 5 years ago

jdmg94 commented 5 years ago

Steps to Reproduce:

1) create a collection named foo 2) right-click the collection and click rename from the context menu 3) enter the name bar on the dialog and click ok

Expected Behaviour: The name entered on the dialog is reflected in the selected collection in the side-bar.

Current Behaviour: nothing happens

jdmg94 commented 5 years ago

as per line: https://github.com/treagod/spectator/blob/b3e424e9dca28cbf12480a04945bbeac16be3921/src/Widgets/Sidebar/Container.vala#L177

the collection update is calling method update on a Models.Collection instance, but if we check the source for the model we don't have an update method defined: https://github.com/treagod/spectator/blob/master/src/Models/Collection.vala

treagod commented 5 years ago

Will fix it as soon as possible. As workaround hit enter after typing the new name

treagod commented 5 years ago

Fixed with 021fa845

btd1337 commented 5 years ago

@treagod Tested and working properly now.

This issue can be closed now.