search

treasure-data / digdag

Workload Automation System
https://www.digdag.io/
Apache License 2.0
1.31k stars 222 forks source link

[feature request] _canceled parameter for some cleanup tasks #1226

Open civitaspo opened 5 years ago

civitaspo commented 5 years ago

Hi all,

I have a feature request. I want _canceled parameter for some cleanup tasks.

When a workflow is canceled, we cannot hook any tasks currently. Sometimes I define a stateful workflow that cannot be defined by one task like using temporary storage. I want to clean up the storage in any case.

ref. https://github.com/treasure-data/digdag/blob/29ef4c68e719940c940b9fdcc35151f2c1bae6bc/digdag-core/src/main/java/io/digdag/core/workflow/WorkflowExecutor.java#L993-L995

yoyama commented 5 years ago

@civitaspo Thanks for your proposal. It will be useful. I don't know we can implement _canceled easily, but I guess we should consider how to support cancelling _canceled tasks. ( normal cancel and forced cancel may be required). Anyway thanks.