Open szyn opened 2 years ago
Can I work on it?
Sure, no problem at all. I appreciate your help as usual 👍
@szyn Which plan is better do you think?
Thank you, I feel that 2 is simple and better for me. What do you think?
I think each of them is good. I'll try latter one.
@szyn I found that fixing all the typing error in reliable way is hard. It is similar problem to newer flow that reports too many type errors. Many type annotations are unclear.
So I will add some any
, that is unclear type and some ts-ignore
, that make type checker skip codes.
Do you agree it?
This approach is based on original approach 2, but it also has some flavor of original approach 1.
any
) don't make sense, and even be ignored sometimes.
any
or ts-ignore
to make type annotations more reilable.any
s and ts-ignore
s after migration.So I will add some any, that is unclear type and some ts-ignore, that make type checker skip codes. Do you agree it?
Yes, I agree with it. And also it looks good to me for the approach you suggested. Thank you for letting me know 👍
See also https://github.com/treasure-data/digdag/pull/1641#issuecomment-932850649 for details.