node-sass is deprecated

treasure-data / digdag

Workload Automation System

https://www.digdag.io/

Apache License 2.0

1.3k stars 221 forks source link

node-sass is deprecated #1748

Closed seiyab closed 1 year ago

seiyab commented 2 years ago

Moving onto dart-sass is recommended. https://sass-lang.com/blog/libsass-is-deprecated

Major drawbacks of node-sass:

No new features will be added.
npm install fails on macOS. https://medium.com/macoclock/fix-broken-node-gyp-issue-for-mac-os-596e4a8bcffd

seiyab commented 2 years ago

Oh I found ~node-sass might be no longer used.~

seiyab commented 2 years ago

This is the commit first node-sass is added. https://github.com/treasure-data/digdag/commit/72fd25f6ca8182d6528e6bf6716e2eaea71fe358

seiyab commented 2 years ago

node-sass is indirectly used. bootstrap-loader uses sass-loader.

yoyama commented 2 years ago

We may need upgrade many libraries and Node.js version. We welcome your contribution 🙂

seiyab commented 2 years ago

Thank you for your comment. I found migration into Dart Sass is not straightforward. bootstrap-loader requires node-sass as a peer dependency. https://github.com/shakacode/bootstrap-loader/blob/2c4c85b86313da033a2104e84895ec87285ad4b5/package.json#L41 So just removing node-sass from digdag-ui dev dependencies doesn't work. Though I think removing bootstrap-loader will be good decision in the long run, it might be hard. I might give up if I cannot come up with a good idea .

seiyab commented 1 year ago

https://github.com/treasure-data/digdag/pull/1757 Done.