search

treasure-data / luigi-td

Luigi Workflow Engine integration for Treasure Data
http://docs.treasuredata.com/articles/luigi
Apache License 2.0
16 stars 15 forks source link

fix deprecated BooleanParameter #8

Closed muddydixon closed 6 years ago

muddydixon commented 6 years ago

Summary

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 94.928% when pulling a7fe9e0cf690ca93fb1150c98a0b4dee328345a5 on muddydixon:fix/deprecated_BooleanParameter into 29a8b41d503532ea9f9ec0a14fafed10d41a8297 on treasure-data:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 94.928% when pulling a7fe9e0cf690ca93fb1150c98a0b4dee328345a5 on muddydixon:fix/deprecated_BooleanParameter into 29a8b41d503532ea9f9ec0a14fafed10d41a8297 on treasure-data:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 94.928% when pulling a7fe9e0cf690ca93fb1150c98a0b4dee328345a5 on muddydixon:fix/deprecated_BooleanParameter into 29a8b41d503532ea9f9ec0a14fafed10d41a8297 on treasure-data:master.

toru-takahashi commented 6 years ago

Thank you for your PR. @yyuu Could you take a look?

It looks BoolParameter was introduced in 1.0.21. BooleanParameter was deprecated in 2.0.0 and removed in 2.5.0. https://github.com/spotify/luigi/pull/1959

Our requirement is luigi>=1.1.2,<2.5.0 So, it looks no problem.

toru-takahashi commented 6 years ago

Thank you!

yyuu commented 6 years ago

Released 0.6.9 to PyPI https://pypi.python.org/pypi/luigi-td/0.6.9