search

treasure-data / luigi-td

Luigi Workflow Engine integration for Treasure Data
http://docs.treasuredata.com/articles/luigi
Apache License 2.0
16 stars 15 forks source link

Fix to use luigi.contrib for s3. #9

Open saku opened 6 years ago

saku commented 6 years ago

From luigi 2.7.0, luigi.s3 was moved to luigi.contrib.s3.

https://github.com/spotify/luigi/releases/tag/2.6.0 https://github.com/spotify/luigi/pull/2181

Because, it raise ImportError.

root@dd21befb6b50:/# luigi.sh
Traceback (most recent call last):
  File "/opt/xxx/summary.py", line 14, in <module>
    import facebook
  File "/opt/xxx/facebook.py", line 1, in <module>
    import core
  File "/opt/xxx/core.py", line 5, in <module>
    import luigi_td
  File "/usr/local/lib/python3.5/dist-packages/luigi_td/__init__.py", line 1, in <module>
    from luigi_td.bulk_import import BulkImport
  File "/usr/local/lib/python3.5/dist-packages/luigi_td/bulk_import.py", line 9, in <module>
    from luigi import s3
ImportError: cannot import name 's3'
coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 94.928% when pulling 413ca7650e8795f9ab2c57bb1ec7502037b34acd on saku:feature/luigi_2_7 into 98f4e6c0e7318f738a7028b8b429085f03272066 on treasure-data:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 94.928% when pulling 413ca7650e8795f9ab2c57bb1ec7502037b34acd on saku:feature/luigi_2_7 into 98f4e6c0e7318f738a7028b8b429085f03272066 on treasure-data:master.