treasure-data / prestogres

PostgreSQL protocol gateway for Presto distributed SQL query engine
Other
292 stars 61 forks source link

Add check next_uri because presto 0.153 may have no data but have data in next_uri #55

Closed wyukawa closed 6 years ago

wyukawa commented 8 years ago

In my environment, I use pentaho and access presto through prestogres.

In presto 0.153, presto 0.154, there is a case without data but has next_uri.

for example,

http://.../1 there is data http://.../2 there is data http://.../3 there is no data http://.../4 there is data ...

In this case, prestogres seems to cancel http://.../4 wrongly.

I check https://github.com/prestodb/presto/wiki/HTTP-Protocol

So I think that prestogres should check next_uri.

Thanks

wontonst commented 8 years ago

This PR already exists. https://github.com/treasure-data/prestogres/pull/52

wontonst commented 8 years ago

Can we please get my PR merged in so others aren't wasting their time? This is a clear bug.

teamsoo commented 8 years ago

@wontonst I think this project is not maintained anymore. no one will come and merge your PR. People’d just use the Teradata’s Presto ODBC driver

wontonst commented 8 years ago

Literally was on the phone with these guys a few months back and they said they'd merge in changes :/

On Thu, Oct 20, 2016 at 8:18 PM, Phakin Cheangkrachange < notifications@github.com> wrote:

@wontonst https://github.com/wontonst I think this project is not maintained anymore. no one will come and merge your PR. People’d just use the Teradata’s Presto ODBC driver

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/treasure-data/prestogres/pull/55#issuecomment-255284116, or mute the thread https://github.com/notifications/unsubscribe-auth/AB773DVDmwbrMgq0aPJO3_zvqXP16OHnks5q2C72gaJpZM4Kaz64 .