treasure-data / serverengine

A framework to implement robust multiprocess servers like Unicorn
Apache License 2.0
756 stars 85 forks source link

socket_manager_unix: Support REUSEPORT option via envvar #103

Closed repeatedly closed 4 years ago

repeatedly commented 4 years ago

We got a balancing issue, incoming data is routed to one worker, from user. I'm not sure this change fixes the problem, but they want to test REUSEPORT option. For test, add SERVERENGINE_USE_SOCKET_REUSEPORT envvar to enable it.

ganmacs commented 4 years ago

Are there any reasons you decided to use ENV var? ServerEngine usually receives such option as actual argument like https://github.com/treasure-data/serverengine#list-of-all-configurations

repeatedly commented 4 years ago

By adding option, we need to modify fluentd for new options. Adding option is easy but remove is hard. envvar is easy for testing.