treasure-data / serverengine

A framework to implement robust multiprocess servers like Unicorn
Apache License 2.0
759 stars 86 forks source link

Tweak SocketManager's port on Windows #108

Closed ashie closed 3 years ago

ashie commented 3 years ago

SocketManger on Windows uses TCP to communicate with workers and it uses 10000 port by default. But this port is known as NDMP(Network Data Management Protocol): https://www.iana.org/assignments/service-names-port-numbers/service-names-port-numbers.xhtml?search=10000 and ServerEngine doesn't provide a way to change it manually.

To resolve the conflict this PR includes following two fixes:

repeatedly commented 3 years ago

Could you consider update appveyor setting to run tests on newer rubies or migrating to github actions after merged this patch?

ashie commented 3 years ago

Could you consider update appveyor setting to run tests on newer rubies or migrating to github actions after merged this patch?

Of course, I'll do it.

repeatedly commented 3 years ago

Merged!

ashie commented 3 years ago

Thanks!