treasure-data / serverengine

A framework to implement robust multiprocess servers like Unicorn
Apache License 2.0
756 stars 85 forks source link

Update CI #110

Closed ashie closed 3 years ago

ashie commented 3 years ago
ashie commented 3 years ago

See https://github.com/ashie/serverengine/pull/3 for test results.

repeatedly commented 3 years ago

appveyor seems to use ruby 1.9.3 on all matrix.

ashie commented 3 years ago

appveyor seems to use ruby 1.9.3 on all matrix.

The same branch works correctly on my forked repository:

I'm not sure why but it's not triggered correctly on this PR.

repeatedly commented 3 years ago

Hmm... I see. Merged for testing.

ashie commented 3 years ago

Hmm, still failed ...

repeatedly commented 3 years ago

ruby 3.0 and ruby 2.7 tests use ruby 1.9 but others use correct version.

ashie commented 3 years ago

Now I've found the cause. image: Visual Studio 2019 should be added: https://www.appveyor.com/docs/windows-images-software/#ruby If it's omitted, the image when the project is created is used.

repeatedly commented 3 years ago

I changed project setting to use "Vistual Studio 2019". If next commit doesn't change the build image, we need to update appveyor.yml.

ashie commented 3 years ago

If next commit doesn't change the build image, we need to update appveyor.yml.

I've created #111 since the next commit doesn't take effect.