Closed ashie closed 3 years ago
@repeatedly Could you take look this?
CI for Windows fails on a test but it's not this PR's issue:
Failures:
1) ServerEngine::BlockingFlag wait_for_set timeout
Failure/Error: elapsed.should >= 0.1 * 0.95
expected: >= 0.095
got: 0.093236
# ./spec/blocking_flag_spec.rb:29:in `block (2 levels) in <top (required)>'
@repeatedly Hi, could you kindly review this PR?
Looks good to me.
@td-dev Does anyone merge this?
Now I've got the permission. Thank you for your review!
On Ruby 3.0, calling WSAGetLastError from Ruby script cannot get a correct error code because Ruby's internal code resets it. Use
Fiddle.win32_last_socket_error
instead if it's availbale. You need fiddle 1.0.8 or later to use it. In addition, when you use RubyInstaller, you need to specify the path of fiddle byRUBYLIB
orruby -I
at this moment because it loads Ruby's bundled fiddle before initializing gem. This is the why we don't add a dependency to fiddle, just only installing fiddle doesn't take effect.e.g.)
See also: