treasure-data / serverengine

A framework to implement robust multiprocess servers like Unicorn
Apache License 2.0
759 stars 86 forks source link

Add base64 and logger gem as dependency for Ruby 3.4 and 3.5 #147

Closed Watson1978 closed 2 months ago

Watson1978 commented 2 months ago

The base64 gem was marked as bundled gem for Ruby 3.4. Ref. https://github.com/ruby/ruby/commit/6500f85927135901f365d2ba1186c5c4f2881f8e

And, the logger gem was marked as bundled gem for Ruby 3.5. Ref. https://github.com/ruby/ruby/commit/d7e558e3c48c213d0e8bedca4fb547db55613f7c

This patch will suppress the following warning message:

socket_manager.rb:23: warning: base64 was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add base64 to your Gemfile or gemspec.

config_loader.rb:18: warning: logger was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
ashie commented 2 months ago

Thanks!